[PATCH 7/7] Return TXed frames to mac80211.

[Pontus Fuchs]

On 2013-05-28 17:28, Kalle Valo wrote:
> Pontus Fuchs <pontus.fuchs at gmail.com> writes:
>
>> On TX done IRQ reap all transferred skbs.
>>
>> Signed-off-by: Pontus Fuchs <pontus.fuchs at gmail.com>
>
> [...]
>
>> @@ -512,11 +534,12 @@ int wcn36xx_dxe_tx(struct wcn36xx *wcn,
>>   	ctl = ctl->next;
>>   	ctl->skb = skb;
>>   	desc = ctl->desc;
>> +	BUG_ON(ctl->bd_cpu_addr);
>
> No BUG_ON() on wireless drivers, please. It just creates more problems
> than solves.
>
> You could use WARN_ON_ONCE() or wcn36xx_warn(). I recommend the latter,
> consumes less memory.

This condition is fatal. If we had recovery/restart in place I would 
have triggered that.

I can add a comment telling this, and if you have a strong opinion 
against using BUG_ON I can turn it into a WARN_ON instead?

//Pontus