[PATCH 7/7] Return TXed frames to mac80211.

Kalle Valo kvalo at qca.qualcomm.com
Tue May 28 11:28:40 EDT 2013


Pontus Fuchs <pontus.fuchs at gmail.com> writes:

> On TX done IRQ reap all transferred skbs.
>
> Signed-off-by: Pontus Fuchs <pontus.fuchs at gmail.com>

[...]

> @@ -512,11 +534,12 @@ int wcn36xx_dxe_tx(struct wcn36xx *wcn,
>  	ctl = ctl->next;
>  	ctl->skb = skb;
>  	desc = ctl->desc;
> +	BUG_ON(ctl->bd_cpu_addr);

No BUG_ON() on wireless drivers, please. It just creates more problems
than solves.

You could use WARN_ON_ONCE() or wcn36xx_warn(). I recommend the latter,
consumes less memory.

-- 
Kalle Valo



More information about the wcn36xx mailing list