[PATCH 1/4] Remove useless void pointer
Pontus Fuchs
pontus.fuchs at gmail.com
Tue May 28 04:05:20 EDT 2013
Fix some formatting issues too.
Signed-off-by: Pontus Fuchs <pontus.fuchs at gmail.com>
---
txrx.c | 17 ++++++-----------
txrx.h | 8 +++-----
2 files changed, 9 insertions(+), 16 deletions(-)
diff --git a/txrx.c b/txrx.c
index 10b797b..316cfee 100644
--- a/txrx.c
+++ b/txrx.c
@@ -75,28 +75,23 @@ int wcn36xx_rx_skb(struct wcn36xx *wcn, struct sk_buff *skb)
return 0;
}
-void wcn36xx_prepare_tx_bd(void *pBd, u32 len, u32 header_len)
+void wcn36xx_prepare_tx_bd(struct wcn36xx_tx_bd *bd, u32 len, u32 header_len)
{
- struct wcn36xx_tx_bd * bd = (struct wcn36xx_tx_bd *)pBd;
- // Must be clean every time because we can have some leftovers from the previous packet
- memset(pBd, 0, (sizeof(struct wcn36xx_tx_bd)));
+ memset(bd, 0, sizeof(*bd));
bd->pdu.mpdu_header_len = header_len;
- bd->pdu.mpdu_header_off = sizeof(struct wcn36xx_tx_bd);
+ bd->pdu.mpdu_header_off = sizeof(*bd);
bd->pdu.mpdu_data_off = bd->pdu.mpdu_header_len +
bd->pdu.mpdu_header_off;
bd->pdu.mpdu_len = len;
}
-void wcn36xx_fill_tx_bd(struct wcn36xx *wcn,
- void *pBd,
- u8 broadcast,
- u8 encrypt)
+void wcn36xx_fill_tx_bd(struct wcn36xx *wcn, struct wcn36xx_tx_bd *bd,
+ u8 broadcast, u8 encrypt)
{
- struct wcn36xx_tx_bd * bd = (struct wcn36xx_tx_bd *)pBd;
bd->dpu_rf = WCN36XX_BMU_WQ_TX;
bd->pdu.tid = WCN36XX_TID;
bd->pdu.reserved3 = 0xd;
- if ( broadcast ) {
+ if (broadcast) {
// broadcast
bd->ub = 1;
bd->queue_id = WCN36XX_TX_B_WQ_ID;
diff --git a/txrx.h b/txrx.h
index 7a3b282..8a4c62d 100644
--- a/txrx.h
+++ b/txrx.h
@@ -143,9 +143,7 @@ struct wcn36xx_tx_bd {
u32 reserved7:6;*/
};
int wcn36xx_rx_skb(struct wcn36xx *wcn, struct sk_buff *skb);
-void wcn36xx_prepare_tx_bd(void *pBd, u32 len, u32 header_len);
-void wcn36xx_fill_tx_bd(struct wcn36xx *wcn,
- void * pBd,
- u8 broadcast,
- u8 encrypt);
+void wcn36xx_prepare_tx_bd(struct wcn36xx_tx_bd *bd, u32 len, u32 header_len);
+void wcn36xx_fill_tx_bd(struct wcn36xx *wcn, struct wcn36xx_tx_bd *bd,
+ u8 broadcast, u8 encrypt);
#endif /* _TXRX_H_ */
--
1.8.1.2
More information about the wcn36xx
mailing list