Let's use checkpatch.pl

Kalle Valo kvalo at qca.qualcomm.com
Tue May 28 03:27:27 EDT 2013


Pontus Fuchs <pontus.fuchs at gmail.com> writes:

> On 2013-05-28 09:17, Kalle Valo wrote:
>> Eugene Krasnikov <k.eugene.e at gmail.com> writes:
>>
>>> To have one coding style let's run checkpatch.pl over every patch. Steps:
>>> 1) Go to kernel repository
>>> 2) run "scripts/checkpatch.pl *.patch"
>>>
>>> This will make our code look better and it will be much easier to
>>> contribute to linux-wireless in this way. If you have any other
>>> suggestions please feel free to send them to mailing list.
>>
>> We should also start running sparse. That's an excellent tool for
>> finding buggy code.
>
> We are sparse clean except for a missing static. Patch pending in my tree :)

Superb! :)

-- 
Kalle Valo



More information about the wcn36xx mailing list