hal config bss failing

[Kalle Valo]

Eugene Krasnikov <k.eugene.e at gmail.com> writes:

> I assume AP has the same rootcase but without logs difficult to say.

With the change below fixes the hal response error for me. Now wcn36xx
doesn't print any errors when I connect to an AP.

> Here is the issue that i am referring to
> https://github.com/KrasnikovEugene/wcn36xx/issues/2

Yeah, we definitely need this. I'll work on a runtime detection what
version of firmware interface is used. Most likely there are even more
firmware interface changes.

Here's the change I did:

diff --git a/hal.h b/hal.h
index 27a79b4..cdb9ac0 100644
--- a/hal.h
+++ b/hal.h
@@ -1103,10 +1103,6 @@ struct wcn36xx_hal_config_sta_params {
        /* Short GI support for 20Mhz packets */
        u8 sgi_20Mhz;
 
-       // TODO move this parameter to the end for 3680
-       /* These rates are the intersection of peer and self
-       capabilities. */
-       struct wcn36xx_hal_supported_rates supported_rates;
-
        /* Robust Management Frame (RMF) enabled/disabled */
        u8 rmf;
 
@@ -1158,7 +1154,11 @@ struct wcn36xx_hal_config_sta_params {
 
        // TODO add this parameter for 3680.
        /* Reserved to align next field on a dword boundary */
-       //u8 reserved;
+       u8 reserved;
+
+       // TODO move this parameter to the end for 3680
+       /* These rates are the intersection of peer and self
        capabilities. */
+       struct wcn36xx_hal_supported_rates supported_rates;
 } __packed;
 
 struct wcn36xx_hal_supported_rates_v1 {

-- 
Kalle Valo