[PATCH 3/7] debug: use printk() instead pr_debug()

[Kalle Valo]

Eugene Krasnikov <k.eugene.e at gmail.com> writes:

> But if let's say problem is on the border of WCN36XX_DBG_SMD and
> WCN36XX_DBG_DXE. To enable both will spam the log a lot but using
> dynamic debug it is possible to disable certain functions that are not
> needed for problem investigation. That's why dynamic debug is really
> flexible.

If enabling two log levels spams too much when our debug messages are
too verbose. That's why I started to make our debug messages more
compact, it's easier to read them when they are compact.

Dynamic debugging is a nice idea but it's not really practical for
wireless driver development due to lack of grouping. Using just line
numbers won't work as line numbers change all the time and there's just
too many of them. And AFAIK none of the other Atheros/QCA upstream
drivers use dynamic debug either.

But if we still preserve dynamic debug support maybe we could implement
something like this:

if debug_mask set
   printk()
else
   pr_debug()

That way if debug_mask is set dynamic debug is bypassed and debug
messages are printed only according to debug_mask. But if debug_mask is
not set, dynamic debug feature is used as earlier. How does that sound?

-- 
Kalle Valo