[PATCH] Fix memory leakage

Eugene Krasnikov k.eugene.e at gmail.com
Fri Jun 14 03:06:23 EDT 2013


With bss_info_changed this will not help much because function does
not return any value and mac80211 will not find out about the problem.
But I will add this check to make all functions look the same;) Will
do that in a separate patch.

2013/6/12 Kalle Valo <kvalo at qca.qualcomm.com>:
> Eugene Krasnikov <k.eugene.e at gmail.com> writes:
>
>>> If think it would be better to bail out from the function if skb is
>>> null.
>>
>> What is the benefit of bailing out from the function in here.
>> bss_info_changed is rather difficult spot since it does not return any
>> value and i do not see any pros and cons of both approaches:) Do you
>> see any benefits from leaving the function as soon as problem
>> occurred?
>
> If we can't get a beacon from mac80211 something is seriously wrong and
> most likely there will be more problems if we try to go further. It's
> good behaviour to just stop the current execution and bail out when an
> unrecoverable error is spotted, that helps avoiding crashes.
>
> --
> Kalle Valo



-- 
Best regards,
Eugene



More information about the wcn36xx mailing list