[PATCH] Fix memory leakage

Kalle Valo kvalo at qca.qualcomm.com
Wed Jun 12 14:45:03 EDT 2013


Eugene Krasnikov <k.eugene.e at gmail.com> writes:

>> If think it would be better to bail out from the function if skb is
>> null.
>
> What is the benefit of bailing out from the function in here.
> bss_info_changed is rather difficult spot since it does not return any
> value and i do not see any pros and cons of both approaches:) Do you
> see any benefits from leaving the function as soon as problem
> occurred?

If we can't get a beacon from mac80211 something is seriously wrong and
most likely there will be more problems if we try to go further. It's
good behaviour to just stop the current execution and bail out when an
unrecoverable error is spotted, that helps avoiding crashes.

-- 
Kalle Valo



More information about the wcn36xx mailing list