[PATCH] Set HT caps in config_sta

Olof Johansson dev at skyshaper.net
Sun Jul 14 05:18:34 EDT 2013


On Fri, Jul 12, 2013 at 4:58 PM, Eugene Krasnikov <k.eugene.e at gmail.com> wrote:
> @@ -561,7 +561,7 @@ static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw,
>                         sta = ieee80211_find_sta(vif, bss_conf->bssid);
>                         if(sta)
>                                 wcn36xx_update_allowed_rates(wcn, sta);
> -                       rcu_read_unlock();
> +
>
>                         wcn36xx_smd_set_link_st(wcn, bss_conf->bssid,
>                                                 vif->addr,
> @@ -569,9 +569,9 @@ static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw,
>                         wcn36xx_smd_config_bss(wcn, vif,
>                                                bss_conf->bssid,
>                                                true, wcn->beacon_interval);
> -                       wcn36xx_smd_config_sta(wcn, vif, bss_conf->bssid,
> +                       wcn36xx_smd_config_sta(wcn, vif, sta, bss_conf->bssid,
>                                                vif->addr);
> -
> +                       rcu_read_unlock();
>                 } else {

I think we should keep the wcn36xx_smd_config_sta call under the
if(sta) statment.


> +static void wcn36xx_smd_set_sta_params(struct ieee80211_sta *sta,
> +               struct wcn36xx_hal_config_sta_params *sta_params)
> +{
> +       if (sta) {
> +               sta_params->wmm_enabled = sta->wme;
> +               sta_params->max_sp_len = sta->max_sp;
> +               wcn36xx_smd_set_sta_ht_params(sta, sta_params);
> +       }
> +}

No use for the if(sta) check here.

Cheers
--
Olof



More information about the wcn36xx mailing list