[PATCH 4/5] Enable Config the keep alive function

[YanBo]

On Mon, Jul 8, 2013 at 3:57 PM, Eugene Krasnikov <k.eugene.e at gmail.com> wrote:
>> +               wcn36xx_enable_keep_alive_null_packet(wcn);
>>                 wcn36xx_pmc_enter_bmps_state(wcn, vif->bss_conf.sync_tsf);
>>                 break;
>
> Do wee need to add keep alive call to WoW . Some where here probably
> https://github.com/KrasnikovEugene/wcn36xx/blob/master/main.c#L742?

It is not a mandatory feature for keep alive, hence suggest separated
it from WOW
>
>> +int wcn36xx_smd_keep_alive_req(struct wcn36xx *wcn, int packet_type)
>> +{
>> +       struct wcn36xx_hal_keep_alive_req_msg msg_body;
>> +
>> +       INIT_HAL_MSG(msg_body, WCN36XX_HAL_KEEP_ALIVE_REQ);
>> +
>> +       if (packet_type == WCN36XX_HAL_KEEP_ALIVE_NULL_PKT) {
>> +               msg_body.bss_index = 0;
>> +               msg_body.packet_type = WCN36XX_HAL_KEEP_ALIVE_NULL_PKT;
>> +               msg_body.time_period = WCN36XX_KEEP_ALIVE_TIME_PERIOD;
>> +       } else if (packet_type == WCN36XX_HAL_KEEP_ALIVE_UNSOLICIT_ARP_RSP) {
>> +               /* TODO: it also support ARP response type */
>
> We desperately need this. ARPs always wake up the host in suspended mode.
>
will implement in later patch.
>
>> +       WCN36XX_DBG_PMC         = 0x00002000,
>> +       WCN36XX_DBG_PMC_DUMP    = 0x00004000,
>
> Probably these enums must be in another patch since they have nothing
> to do with keep alive functionality right

There are debug log be controlled by mark in keep alive function.
>
> --
> Best regards,
> Eugene