[PATCH 3/5] Add the DUMP command interface which can be used contro the FW action

[Eugene Krasnikov]

> echo 13 6 3 1 means open all CXM module log

Could you please add all possible values or to commit or to readme? Like:
echo 13 6 3 1 means open all CXM module log
echo 13 7 3 1 means open all XXX module log

And so on...

> +       tmp = buf;

What is the point to have this tmp variable? Why not to use buf?

> +#define WCN36xx_MAX_DUMP_ARGS  5

xx must be XX

>  struct wcn36xx_hal_dump_cmd_req_msg {
>         struct wcn36xx_hal_msg_header header;
>
> -       u32 argument1;
> -       u32 argument2;
> -       u32 argument3;
> -       u32 argument4;
> -       u32 argument5;
> +       u32 arg1;
> +       u32 arg2;
> +       u32 arg3;
> +       u32 arg4;
> +       u32 arg5;
>  };

Must be packed.

>
>  struct wcn36xx_hal_dump_cmd_rsp_msg {

Also must be packed.

--
Best regards,
Eugene