[PATCH] Add the debug filesystem framework

[YanBo]

On Thu, Jul 4, 2013 at 2:46 PM, Eugene Krasnikov <k.eugene.e at gmail.com> wrote:
>> +void wcn36xx_debugfs_init(struct wcn36xx *wcn)
>> +{
>> +       struct wcn36xx_dfs_entry *dfs = &wcn->dfs;
>> +
>> +       dfs->rootdir = debugfs_create_dir(KBUILD_MODNAME, NULL);
>
> dfs must be created within wihpy space but not in root so i suggest to
> add something like wiphy->debugfs as a second parameter to
> debugfs_create_dir.
>

That is reasonable. will change in next version.


>
>> +       struct wcn36xx_dfs_file file_bmps_switcher;
>
> Is this used somewhere in this patch? i guess it's for future patches
> so suggest to move this parameter to the next patch.
>
Good catch, it is do used for the next BMPS switcher patch
>
> --
> Best regards,
> Eugene