[PATCH] Add the power save control framework and debugfs entry

Eugene Krasnikov k.eugene.e at gmail.com
Thu Jul 4 03:25:51 EDT 2013


> +       /* TODO:Disable the TX queue */

Do we really need to stop TX here? AFAIK it is possible to send frames
even in bmps mode right?

>         struct wcn36xx_vif      *current_vif;
> +       struct ieee80211_vif    *vif; /* For debug get the tsf info */

There is no need to store 2 pointers for both wcn36xx_vif  and
ieee80211_vif. Let's just replace wcn36xx_vif  with ieee80211_vif.
What do you think about that?

> +       /* Power management */
> +       enum wcn36xx_power_state     pw_state;
> +

I suggest to replace is_suspended parameters with pw_state what do you think?

--
Best regards,
Eugene



More information about the wcn36xx mailing list