[PATCH] Add the debug filesystem framework
Eugene Krasnikov
k.eugene.e at gmail.com
Thu Jul 4 02:51:20 EDT 2013
> + debugfs_remove(dfs->rootdir);
debugfs_remove_recursive?
2013/7/4 Eugene Krasnikov <k.eugene.e at gmail.com>:
>> +void wcn36xx_debugfs_init(struct wcn36xx *wcn)
>> +{
>> + struct wcn36xx_dfs_entry *dfs = &wcn->dfs;
>> +
>> + dfs->rootdir = debugfs_create_dir(KBUILD_MODNAME, NULL);
>
> dfs must be created within wihpy space but not in root so i suggest to
> add something like wiphy->debugfs as a second parameter to
> debugfs_create_dir.
>
>
>> + struct wcn36xx_dfs_file file_bmps_switcher;
>
> Is this used somewhere in this patch? i guess it's for future patches
> so suggest to move this parameter to the next patch.
>
>
> --
> Best regards,
> Eugene
--
Best regards,
Eugene
More information about the wcn36xx
mailing list