[PATCH 4/6] Remove redundant comments

Eugene Krasnikov k.eugene.e at gmail.com
Mon Aug 5 09:56:19 EDT 2013


Comments are not needed in those places.

Signed-off-by: Eugene Krasnikov <k.eugene.e at gmail.com>
---
 main.c | 1 -
 smd.c  | 8 ++------
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/main.c b/main.c
index c18b321..57601cb 100644
--- a/main.c
+++ b/main.c
@@ -893,7 +893,6 @@ static int wcn36xx_init_ieee80211(struct wcn36xx *wcn)
 	wcn->hw->wiphy->wowlan = &wowlan_support;
 #endif
 
-	/* TODO make a conf file where to read this information from */
 	wcn->hw->max_listen_interval = 200;
 
 	wcn->hw->queues = 4;
diff --git a/smd.c b/smd.c
index 4eaa07e..7ede50c 100644
--- a/smd.c
+++ b/smd.c
@@ -434,7 +434,6 @@ int wcn36xx_smd_update_scan_params(struct wcn36xx *wcn)
 
 	INIT_HAL_MSG(msg_body, WCN36XX_HAL_UPDATE_SCAN_PARAM_REQ);
 
-	/* TODO read this from config */
 	msg_body.dot11d_enabled	= 0;
 	msg_body.dot11d_resolved = 0;
 	msg_body.channel_count = 26;
@@ -1024,7 +1023,7 @@ int wcn36xx_smd_send_beacon(struct wcn36xx *wcn, struct sk_buff *skb_beacon,
 		    msg_body.beacon_length);
 
 	return wcn36xx_smd_send_and_wait(wcn, msg_body.header.len);
-};
+}
 
 int wcn36xx_smd_update_proberesp_tmpl(struct wcn36xx *wcn, struct sk_buff *skb)
 {
@@ -1032,9 +1031,6 @@ int wcn36xx_smd_update_proberesp_tmpl(struct wcn36xx *wcn, struct sk_buff *skb)
 
 	INIT_HAL_MSG(msg, WCN36XX_HAL_UPDATE_PROBE_RSP_TEMPLATE_REQ);
 
-	/* // TODO need to find out why this is needed? */
-	/* msg_body.beacon_length = skb_beacon->len + 6; */
-
 	if (skb->len > BEACON_TEMPLATE_SIZE) {
 		wcn36xx_warn("probe response template is too big: %d",
 			     skb->len);
@@ -1053,7 +1049,7 @@ int wcn36xx_smd_update_proberesp_tmpl(struct wcn36xx *wcn, struct sk_buff *skb)
 		    msg.probe_resp_template_len, msg.bssid);
 
 	return wcn36xx_smd_send_and_wait(wcn, msg.header.len);
-};
+}
 
 int wcn36xx_smd_set_stakey(struct wcn36xx *wcn,
 			   enum ani_ed_type enc_type,
-- 
1.8.2.2




More information about the wcn36xx mailing list