[PATCH 3/6] Remove logging from memory barriers

Eugene Krasnikov k.eugene.e at gmail.com
Mon Aug 5 09:56:18 EDT 2013


Memory barriers must be handled right after memory access.

Signed-off-by: Eugene Krasnikov <k.eugene.e at gmail.com>
---
 dxe.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/dxe.c b/dxe.c
index 60c43b5..fb7969c 100644
--- a/dxe.c
+++ b/dxe.c
@@ -36,24 +36,22 @@ void *wcn36xx_dxe_get_next_bd(struct wcn36xx *wcn, bool is_low)
 
 static void wcn36xx_dxe_write_register(struct wcn36xx *wcn, int addr, int data)
 {
-	wmb();
-
 	wcn36xx_dbg(WCN36XX_DBG_DXE,
 		    "wcn36xx_dxe_write_register: addr=%x, data=%x",
 		    addr, data);
 
+	wmb();
 	writel_relaxed(data, wcn->mmio + addr);
 }
 
 static void wcn36xx_dxe_read_register(struct wcn36xx *wcn, int addr, int *data)
 {
 	*data = readl_relaxed(wcn->mmio + addr);
+	rmb();
 
 	wcn36xx_dbg(WCN36XX_DBG_DXE,
 		    "wcn36xx_dxe_read_register: addr=%x, data=%x",
 		    addr, *data);
-
-	rmb();
 }
 
 static void wcn36xx_dxe_free_ctl_block(struct wcn36xx_dxe_ch *ch)
-- 
1.8.2.2




More information about the wcn36xx mailing list