[PATCH] info to atm layer about broken connection

Stanislaw Gruszka stf_xl at wp.pl
Sun Oct 30 16:44:09 EST 2005

Hi Duncan
> Hi Staszek, thanks for the patch, however I think this is the
> wrong approach.  The right thing to do is to go through the list
> of vccs and do vcc_release_async() on each one.  
vcc_release_async() don't work with pppoatm, I don't know why,
simply after disconnect modem, ppp demon still works 
and ifconfig command show me connection is ok.
Using vcc->push(vcc, NULL) kill pppd with
Modem hangup message in logs.

> Also, as far as I can see the use of try_module_get is pointless.  Why do
> you think it is needed?
It depends on approach, someone would like to finish connection when 
net driver module is unloaded, other one would like to prevent unloading 
module. I preffer second approach as is in (for example) pppoatm .

Adding try_module_get and module_put pair in subdriver atm_start() and atm_stop() 
propably block unload module anyway.

Staszek Gruszka

More information about the Usbatm mailing list