speedtch usbatm.h,1.3,1.4 usbatm2.c,1.12,1.13

Roman Kagan rkagan at mail.ru
Fri Jan 28 06:42:49 EST 2005


  Hi Duncan,

On Fri, Jan 28, 2005 at 11:03:46AM +0000, Duncan Sands wrote:
> Manage our own kernel thread, much the same as Roman's patch except that we
> shoot the thread down with SIGTERM.  This is racy though:
> 
> (1) the thread may have finished and someone may be using the pid -> we shoot
> down the wrong process.

Oh, no, that looks wrong.
Most of the time you'll be disconnecting the modem long after you
connected it, by which time the pids are quite likely overflown and
you're pretty certain to kill a wrong process.

IMO either rely on it to behave or let it die asynchronously.

Cheers,
  Roman.



More information about the Usbatm mailing list