speedtch usbatm.h,1.4,1.5 usbatm2.c,1.13,1.14

[Duncan Sands]

Hi Matthieu,

> > which bogus kfree do you mean?  I see a kfree in udsl_destroy_instance,
> > but it looks fine to me...
> 
> the kfree is done on data which is statically initialized by the driver, 
> so the kfree is is bogus.

ah yes - the old usbatm setup, I'd completely forgotten about it!

> But even if we remove the kfree, it won't solve the problem, since we 
> can unload the driver and erase the instance data(loading an other 
> module that reuse the memory where the instance was stored), and if 
> usbatm try to access to this (from atm call for example) it with panic...

Maybe usbatm should take a module reference to the driver, and drop it
in udsl_destroy_instance?

Ciao,

D.