[PATCH v2] ipq40xx: google (gale) add reset button

Brian Norris computersforpeace at gmail.com
Wed Mar 29 21:38:18 PDT 2023


On Sun, Mar 26, 2023 at 10:50:42PM +0200, openwrt at aiyionpri.me wrote:
> From: Jan-Niklas Burfeind <git at aiyionpri.me>
> 
> add the external button (GPIO 57) as reset button
> 
> Co-authored-by: Brian Norris <computersforpeace at gmail.com>
> Signed-off-by: Jan-Niklas Burfeind <git at aiyionpri.me>
> ---
> 
> I added the phandle for fw_pinmux and used it as you suggested.
> Furthermore added the function gpio similar to your referenced PR.
> 
> Hopefully this reflects your intentions.
> 
> I just compiled and tested it again, resetting still works with the
> added changes.
> 
> Have a nice evening everyone and thanks for reviewing this
> aiyion

Thanks for the v2. Looks and works fine for me:

Reviewed-by: Brian Norris <computersforpeace at gmail.com>
Tested-by: Brian Norris <computersforpeace at gmail.com>

I think you have an extra space in the patch subject, but presumably
somebody could fix that one up when committing it for real.



More information about the openwrt-devel mailing list