[OpenWrt-Devel] [PATCH] treewide: add Generic subtarget if missing

mail at adrianschmutzler.de mail at adrianschmutzler.de
Sun Sep 15 06:40:46 EDT 2019


> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Jonas Gorski
> Sent: Samstag, 14. September 2019 11:54
> To: Paul Spooren <mail at aparcar.org>
> Cc: Sergey Ryazanov <ryazanov.s.a at gmail.com>; Tomasz Maciej Nowak
> <tomek_n at o2.pl>; Roman Yeryomin <roman at advem.lv>; Tim Harvey
> <tharvey at gateworks.com>; Luka Perkov <luka at openwrt.org>; Jason Wu
> <jason.wu.misc at gmail.com>; Alexander Couzens <lynxis at fe80.eu>; John
> Crispin <john at phrozen.org>; OpenWrt Development List <openwrt-
> devel at lists.openwrt.org>; Felix Fietkau <nbd at nbd.name>
> Subject: Re: [OpenWrt-Devel] [PATCH] treewide: add Generic subtarget if
> missing
> On Fri, 23 Aug 2019 at 11:04, Paul Spooren <mail at aparcar.org> wrote:
> > As in 853e4dd OpenWrt should follow a unified structure, where every
> > device has a target/subtarget combination, if there is only one
> > subtarget, call it "Generic". This introduces predictable filenames.
> If it's about (I assume generated) filenames, wouldn't it be easier to just use
> "Generic" for the subtarget part of the filename if there are no subtargets?
> I'm not really a fan of unnecessary code fluff without any real function,
> especially if it means additional, mainly empty files.

What you suggest is about what we have right now. This kind of creates a misleading situation where for some targets subtargets are present, while for others paths and image names are "fixed" in several places to include a "generic". The reason for Paul's patch was to get rid of the fixes at individual places (which was/is applied somewhat inconsistently) by just making all targets apply to the same logic (i.e. that there is at least one subtarget).
So, the empty files are introduced to make the process of building and creating images afterwards simpler (to follow/understand).

I was suffering from the same problem when I dealt with OpenWrt-derived firmware, where I suddenly encountered a target without subtargets and had to implement extra code to work around that.

However, I also wondered whether one couldn't code around the necessity of the empty file, and just add the SUBTARGET/SUBTARGETS variables here...



> Regards
> Jonas
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190915/24b0cf09/attachment.sig>
-------------- next part --------------
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list