[OpenWrt-Devel] [PATCH v2 1/2] ramips/mt762x: convert devices to interrupt-driven gpio-keys

Adrian Schmutzler mail at adrianschmutzler.de
Mon Oct 21 08:30:57 EDT 2019


Hi John,

> -----Original Message-----
> From: John Crispin [mailto:john at phrozen.org]
> Sent: Montag, 21. Oktober 2019 14:19
> To: Adrian Schmutzler <freifunk at adrianschmutzler.de>; openwrt-devel at lists.openwrt.org
> Subject: Re: [OpenWrt-Devel] [PATCH v2 1/2] ramips/mt762x: convert devices to interrupt-driven gpio-keys
> 
> 
> On 21/10/2019 14:17, John Crispin wrote:
> > On 20/09/2019 14:03, Adrian Schmutzler wrote:
> >> This converts all remaining devices to use interrupt-driven
> >> gpio-keys compatible instead of gpio-keys-polled.
> >> The poll-interval is removed.
> >>
> >> While at it, add/remove newlines in keys and leds node where
> >> necessary.
> >>
> >> Signed-off-by: Adrian Schmutzler <freifunk at adrianschmutzler.de>
> >
> > Hi,
> > was there not an issue on some of the older ralink silicon versions that
> > made irq unreliable, which is why we never changed this ?
> >      John
> this only touches the mtk silicon ...

I obviously cannot prove that this will work on all devices, but I have seen several device support PRs for mt7620/mt7621/mt7628 with gpio-keys working (=tested) over the last half year.
I intentionally only included mt76xx here, as I have no idea whether this will work on rtxxxx, and if I remember correctly 100 % of them still have gpio-keys-polled set.

Best

Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20191021/aa086420/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list