[PATCH v2 2/5] lib: Add SBIUnit testing macros and functions

Ivan Orlov ivan.orlov0322 at gmail.com
Wed Feb 28 09:10:11 PST 2024


On 2/28/24 17:00, Andrew Jones wrote:
> On Wed, Feb 28, 2024 at 04:43:59PM +0000, Ivan Orlov wrote:
>> On 2/28/24 16:30, Andrew Jones wrote:
>>
>>> If a no-name test is OK, then the stop condition should be
>>> s_case->test_func being NULL.
>>>
>>
>> Yeah, I guess we can check the test_func. Thanks!
>>
>> Also, I believe it would be good to mention that we need the last test cases
>> array entry to be empty in the documentation, so it will be more explicit
>> for a developer. I'll do that in the V3 if it is OK with you.
>>
> 
> Sure. You can define an 'END_CASE = { }' type of macro and put it in the
> document's code examples. That'd probably be enough, but you could also
> add a sentence to explicitly state it's required too.
> 

Great, thanks! Perhaps I could define it as SBIUNIT_END_CASE macro and 
use in other tests as well.
-- 
Kind regards,
Ivan Orlov




More information about the opensbi mailing list