[PATCH 1/5] lib: simplify fdt_parse_plmt_node()
Yu-Chien Peter Lin
peterlin at andestech.com
Sun Nov 27 23:50:22 PST 2022
On Fri, Nov 25, 2022 at 03:08:23PM +0100, Heinrich Schuchardt wrote:
> We should not check !plmt_base || !plmt_size twice.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
Looks good to me.
Reviewed-by: Yu Chien Peter Lin <peterlin at andestech.com>
> ---
> lib/utils/fdt/fdt_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/utils/fdt/fdt_helper.c b/lib/utils/fdt/fdt_helper.c
> index 89b8bba..dbd7484 100644
> --- a/lib/utils/fdt/fdt_helper.c
> +++ b/lib/utils/fdt/fdt_helper.c
> @@ -814,7 +814,7 @@ int fdt_parse_plmt_node(void *fdt, int nodeoffset, unsigned long *plmt_base,
>
> rc = fdt_get_node_addr_size(fdt, nodeoffset, 0,
> ®_addr, ®_size);
> - if (rc < 0 || !plmt_base || !plmt_size)
> + if (rc < 0)
> return SBI_ENODEV;
> *plmt_base = reg_addr;
> *plmt_size = reg_size;
> --
> 2.37.2
More information about the opensbi
mailing list