[PATCH 1/5] lib: simplify fdt_parse_plmt_node()

Xiang W wxjstz at 126.com
Sat Nov 26 04:54:37 PST 2022


在 2022-11-25星期五的 15:08 +0100,Heinrich Schuchardt写道:
> We should not check !plmt_base || !plmt_size twice.
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
Look good to me

Reviewed-by: Xiang W <wxjstz at 126.com>
> ---
>  lib/utils/fdt/fdt_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/utils/fdt/fdt_helper.c b/lib/utils/fdt/fdt_helper.c
> index 89b8bba..dbd7484 100644
> --- a/lib/utils/fdt/fdt_helper.c
> +++ b/lib/utils/fdt/fdt_helper.c
> @@ -814,7 +814,7 @@ int fdt_parse_plmt_node(void *fdt, int nodeoffset, unsigned long *plmt_base,
>  
>         rc = fdt_get_node_addr_size(fdt, nodeoffset, 0,
>                                     &reg_addr, &reg_size);
> -       if (rc < 0 || !plmt_base || !plmt_size)
> +       if (rc < 0)
>                 return SBI_ENODEV;
>         *plmt_base = reg_addr;
>         *plmt_size = reg_size;
> -- 
> 2.37.2
> 
> 





More information about the opensbi mailing list