[PATCH] firmware: payloads: Remove duplicate "ALIGN"

Bin Meng bmeng.cn at gmail.com
Mon Nov 14 08:06:14 PST 2022


On Tue, Nov 8, 2022 at 6:12 PM <1220749046 at qq.com> wrote:
>
> From: zhangleizheng <zhangleizheng at eswincomputing.com>

nits: please use <First Name> <Last Name> format as the git user.name

>
> ". = ALIGN(0x1000)" is used redundantly in firmware/fw_base.ldS
> and fw_base.ldS files.

and firmware/payloads/test.elf.ldS files

>
> Signed-off-by: zhangleizheng <zhangleizheng at eswincomputing.com>
> ---
>  firmware/fw_base.ldS           | 2 --
>  firmware/payloads/test.elf.ldS | 2 --
>  2 files changed, 4 deletions(-)
>
> diff --git a/firmware/fw_base.ldS b/firmware/fw_base.ldS
> index 220c043..382da25 100644
> --- a/firmware/fw_base.ldS
> +++ b/firmware/fw_base.ldS
> @@ -24,8 +24,6 @@
>                 PROVIDE(_text_end = .);
>         }
>
> -       . = ALIGN(0x1000); /* Ensure next section is page aligned */
> -
>         /* End of the code sections */

nits: I would put ". = ALIGN(0x1000)" here in between the comments

and fix other ". = ALIGN(0x1000)" locations in this file too.

>
>         /* Beginning of the read-only data sections */
> diff --git a/firmware/payloads/test.elf.ldS b/firmware/payloads/test.elf.ldS
> index f3f3242..763103c 100644
> --- a/firmware/payloads/test.elf.ldS
> +++ b/firmware/payloads/test.elf.ldS
> @@ -33,8 +33,6 @@ SECTIONS
>                 PROVIDE(_text_end = .);
>         }
>
> -       . = ALIGN(0x1000); /* Ensure next section is page aligned */
> -
>         /* End of the code sections */
>
>         /* Beginning of the read-only data sections */
> --

Regards,
Bin



More information about the opensbi mailing list