[PATCH] firmware: payloads: Remove duplicate "ALIGN"

Atish Patra atishp at atishpatra.org
Sat Nov 12 01:03:52 PST 2022


On Tue, Nov 8, 2022 at 2:11 AM <1220749046 at qq.com> wrote:
>
> From: zhangleizheng <zhangleizheng at eswincomputing.com>
>
> ". = ALIGN(0x1000)" is used redundantly in firmware/fw_base.ldS
> and fw_base.ldS files.
>
> Signed-off-by: zhangleizheng <zhangleizheng at eswincomputing.com>
> ---
>  firmware/fw_base.ldS           | 2 --
>  firmware/payloads/test.elf.ldS | 2 --
>  2 files changed, 4 deletions(-)
>
> diff --git a/firmware/fw_base.ldS b/firmware/fw_base.ldS
> index 220c043..382da25 100644
> --- a/firmware/fw_base.ldS
> +++ b/firmware/fw_base.ldS
> @@ -24,8 +24,6 @@
>                 PROVIDE(_text_end = .);
>         }
>
> -       . = ALIGN(0x1000); /* Ensure next section is page aligned */
> -
>         /* End of the code sections */
>
>         /* Beginning of the read-only data sections */
> diff --git a/firmware/payloads/test.elf.ldS b/firmware/payloads/test.elf.ldS
> index f3f3242..763103c 100644
> --- a/firmware/payloads/test.elf.ldS
> +++ b/firmware/payloads/test.elf.ldS
> @@ -33,8 +33,6 @@ SECTIONS
>                 PROVIDE(_text_end = .);
>         }
>
> -       . = ALIGN(0x1000); /* Ensure next section is page aligned */
> -
>         /* End of the code sections */
>
>         /* Beginning of the read-only data sections */
> --
> 2.17.1
>
>
> --
> opensbi mailing list
> opensbi at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi

Good catch.

Reviewed-by: Atish Patra <atishp at rivosinc.com>

-- 
Regards,
Atish



More information about the opensbi mailing list