[PATCH] lib: utils/reset: Add voltage level for gpio_reset

Xiang W wxjstz at 126.com
Sun Oct 24 11:09:10 PDT 2021


在 2021-10-24星期日的 18:26 +0100,Jessica Clarke写道:
> > > 
> > > This property is neither documented in the binding specification
> > > for
> > > gpio-restart nor is it checked by Linux.
> > 
> > This DT is only processed by opensbi, and linux should be reset
> > through
> > the sbi interface, instead of controlling gpio to perform the reset
> > by
> > itself.
> 
> Well, there are several things going on:
> 
> 1. In general, you can’t just make up properties in the global
>    namespace, that’s how you end up with the kind of mess device
> trees
>    have the reputation of having
> 2. Linux doesn’t need this property and supports far more hardware
> than
>    OpenSBI does, so why does OpenSBI need knowledge of this property
> but
>    Linux doesn’t on any platform for any architecture?
> 3. OpenSBI doesn’t provide the device tree, in general, pre-OpenSBI
>    firmware does, be it U-Boot SPL or something else, and in general
> that
>    device tree *will* make its way all the way to the OS. Linux might
> go and
>    ignore that and use its own device tree because the whole
> situation is a
>    mess, but that’s not the point, this can and will be exposed to
> OSes running
>    on top.
> 
> Jess

These attributes are under the gpio-restart/gpio-poweroff node and are
not global attributes. If you need to rename, you can submit a new
patch. The rename is added to the current patch, and the commit cannot
be kept clean

Regards,
Xiang W




More information about the opensbi mailing list