[PATCH v5] Makefile: Add build time and compiler info string

Anup Patel anup at brainfault.org
Mon Oct 18 03:08:21 PDT 2021


On Mon, Oct 18, 2021 at 1:42 PM Bin Meng <bmeng.cn at gmail.com> wrote:
>
> On Mon, Oct 18, 2021 at 3:44 PM Andreas Schwab <schwab at linux-m68k.org> wrote:
> >
> > On Okt 18 2021, Bin Meng wrote:
> >
> > > If this BUILD_DATE_EPOCH is not needed at all, I am not sure why do we
> > > still keep
> >
> > BUILD_DATE_EPOCH is also non-standard.  The standard variable is
> > SOURCE_DATE_EPOCH.
> >
>
> Yep, it's SOURCE_DATE_EPOCH in v4, not sure why Anup changed the name in v5.

Yes, I changed it to BUILD_DATE_EPOCH to imply that it is related to
BUILD_INFO. I was not aware that SOURCE_DATE_EPOCH is a
standard name. I will rename it to SOURCE_DATE_EPOCH in v6.

>
> SOURCE_DATE_EPOCH is well documented and is the way for distros to
> generate "reproducible builds".
>
> I would vote to completely drop the "BUILD_INFO=y" as it is not necessary.

I don't agree with this. The BUILD_INFO helps us totally disable build
information whereas SOURCE_DATE_EPOCH helps us override the
build date/time when BUILD_INFO=y.

Regards,
Anup



More information about the opensbi mailing list