[PATCH v2 0/5] I2C framework, reboot Unmatched via PMIC

Jessica Clarke jrtc27 at jrtc27.com
Fri Oct 15 06:44:58 PDT 2021


On 15 Oct 2021, at 14:19, Nikita Shubin <nikita.shubin at maquefel.me> wrote:
> 
> From: Nikita Shubin <n.shubin at yadro.com>
> 
> This series introduce rebooting via i2c da9063 PMIC, currently on
> SiFive Unmatched board.
> 
> "gpio-poweroff" remains with default priority of 128 - default priority,
> da9063 is 1 by default the least priority.
> 
> da9063-reset {
> 	compatible = "da9063-reset";
> 	priority = <1>;
> };

I don’t see why priority is needed; the DA9063 is known to always be a
last-resort way to reboot. Just hard-code it as the lowest priority. I
also don’t see why we need a device tree node, just make it a platform
quirk, because this isn’t (and shouldn’t be) a standardised thing?
Definitely don’t want it being exposed to anything other than OpenSBI,
which is what ends up happening if it lives in the device tree...

Jess




More information about the opensbi mailing list