[PATCH 1/1] firware: use __SIZEOF_LONG__ for field offsets in fw_dynamic.h

Anup Patel anup at brainfault.org
Sat Jul 17 05:17:27 PDT 2021


On Mon, Jul 12, 2021 at 6:38 PM Bin Meng <bmeng.cn at gmail.com> wrote:
>
> On Mon, Jul 12, 2021 at 5:25 PM Alex Richardson
> <Alexander.Richardson at cl.cam.ac.uk> wrote:
> >
> > The fields are of type unsigned long and are not pointers. While this
> > happens to be the same for RV32/RV64, it is not correct when compiling
> > for a CHERI-RISC-V system where pointers are twice the size of long.
> >
> > Signed-off-by: Alex Richardson <Alexander.Richardson at cl.cam.ac.uk>
> > ---
> >  include/sbi/fw_dynamic.h | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

Looks good to me.

Reviewed-by: Anup Patel <anup.patel at wdc.com>

Applied this patch to the riscv/opensbi repo.

Thanks,
Anup

>
> --
> opensbi mailing list
> opensbi at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi



More information about the opensbi mailing list