[PATCH v5 4/6] firmware: Only default FW_PIC to y if supported

Bin Meng bmeng.cn at gmail.com
Sun Jul 11 05:37:42 PDT 2021


On Sun, Jul 11, 2021 at 10:29 AM Jessica Clarke <jrtc27 at jrtc27.com> wrote:
>
> Bare-metal GNU ld does not support PIE, so if using it this will result
> in a failure to build. Instead, default to FW_PIC=n if not supported.
> Note that an explicit FW_PIC=y is not overriden, to ensure the build

typo: overridden

> fails rather than silently producing a position-dependent binary.
>
> Signed-off-by: Jessica Clarke <jrtc27 at jrtc27.com>
> ---
>  Makefile            | 3 +++
>  firmware/objects.mk | 2 +-
>  2 files changed, 4 insertions(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
Tested-by: Bin Meng <bmeng.cn at gmail.com>



More information about the opensbi mailing list