[PATCH v5 2/6] fw_base: Put data in .data rather than .text
Jessica Clarke
jrtc27 at jrtc27.com
Sat Jul 10 19:28:20 PDT 2021
The -N linker option is supposed to make .text writable, but GNU ld and
LLD differ in interpreting what that means. GNU ld will happily let you
have relocations in it, but LLD will see that the input section is
read-only (even though the output section is writable) and give an
error. It's unclear if either of them intend to have that behaviour in
this edge case, but regardless there's no reason not to just put the
data in a writable .data section.
Signed-off-by: Jessica Clarke <jrtc27 at jrtc27.com>
Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
Tested-by: Bin Meng <bmeng.cn at gmail.com>
---
firmware/fw_base.S | 1 +
1 file changed, 1 insertion(+)
diff --git a/firmware/fw_base.S b/firmware/fw_base.S
index ee2a51b..f8aea05 100644
--- a/firmware/fw_base.S
+++ b/firmware/fw_base.S
@@ -501,6 +501,7 @@ _skip_trap_exit_rv32_hyp:
/* We don't expect to reach here hence just hang */
j _start_hang
+ .data
.align 3
#ifdef FW_PIC
_runtime_offset:
--
2.31.0
More information about the opensbi
mailing list