[PATCH v5 1/6] fw_base: Don't mark fw_platform_init as both global and weak
Jessica Clarke
jrtc27 at jrtc27.com
Sat Jul 10 19:28:19 PDT 2021
These are mutually exclusive. GNU as and LLVM both let later binding
directives override earlier ones so this works as intended, but LLVM 12
turned this into a warning as there's no good reason to do such a thing
and could be a potential bug. Thus, remove the redundant and incorrect
.globl directive for fw_platform_init.
Signed-off-by: Jessica Clarke <jrtc27 at jrtc27.com>
Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
Tested-by: Bin Meng <bmeng.cn at gmail.com>
---
firmware/fw_base.S | 1 -
1 file changed, 1 deletion(-)
diff --git a/firmware/fw_base.S b/firmware/fw_base.S
index a5ce946..ee2a51b 100644
--- a/firmware/fw_base.S
+++ b/firmware/fw_base.S
@@ -553,7 +553,6 @@ _start_hang:
.section .entry, "ax", %progbits
.align 3
- .globl fw_platform_init
.weak fw_platform_init
fw_platform_init:
add a0, a1, zero
--
2.31.0
More information about the opensbi
mailing list