[PATCH v4 1/5] fw_base: Don't mark fw_platform_init as both global and weak

Bin Meng bmeng.cn at gmail.com
Fri Jul 9 19:30:04 PDT 2021


On Sat, Jul 10, 2021 at 3:35 AM Jessica Clarke <jrtc27 at jrtc27.com> wrote:
>
> These are mutually exclusive. GNU as and LLVM both let later binding
> directives override earlier ones so this works as intended, but LLVM 12
> turned this into a warning as there's no good reason to do such a thing
> and could be a potential bug. Thus, remove the redundant and incorrect
> .globl directive for fw_platform_init.
> ---
>  firmware/fw_base.S | 1 -
>  1 file changed, 1 deletion(-)
>

You SoB tag was missed again:

Signed-off-by: Jessica Clarke <jrtc27 at jrtc27.com>

And please include people's RB / TB tags in the newer version, if
nothing changed:

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
Tested-by: Bin Meng <bmeng.cn at gmail.com>



More information about the opensbi mailing list