[PATCH 2/2] staging: vc04_services: Add outstanding VCHI TODOs

Eric Anholt eric at anholt.net
Tue Mar 20 17:08:27 PDT 2018


Stefan Wahren <stefan.wahren at i2se.com> writes:

> The TODO list missed some issues before we can move the driver out of staging.
>
> Signed-off-by: Stefan Wahren <stefan.wahren at i2se.com>
> ---
>  drivers/staging/vc04_services/interface/vchi/TODO | 27 +++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/drivers/staging/vc04_services/interface/vchi/TODO b/drivers/staging/vc04_services/interface/vchi/TODO
> index 84e6733..7144de2 100644
> --- a/drivers/staging/vc04_services/interface/vchi/TODO
> +++ b/drivers/staging/vc04_services/interface/vchi/TODO
> @@ -23,3 +23,30 @@ there's a lot code that got built that's probably unnecessary these
>  days.  Once we have the set of VCHI-using drivers we want in tree, we
>  should be able to do a sweep of the code to see what's left that's
>  unused.
> +
> +3) Make driver more portable
> +
> +Building this driver with arm/multi_v7_defconfig or arm64/defconfig
> +leads to data corruption during vchiq_test. This should be fixed.

Sounds good, but could you document that it's "vchiq_test -f" for
testing this?

With that, these two get my:

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-rpi-kernel/attachments/20180320/43eff7c2/attachment.sig>


More information about the linux-rpi-kernel mailing list