[PATCH 2/2] staging: vc04_services: Add outstanding VCHI TODOs

Stefan Wahren stefan.wahren at i2se.com
Tue Mar 20 13:20:02 PDT 2018

The TODO list missed some issues before we can move the driver out of staging.

Signed-off-by: Stefan Wahren <stefan.wahren at i2se.com>
 drivers/staging/vc04_services/interface/vchi/TODO | 27 +++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/drivers/staging/vc04_services/interface/vchi/TODO b/drivers/staging/vc04_services/interface/vchi/TODO
index 84e6733..7144de2 100644
--- a/drivers/staging/vc04_services/interface/vchi/TODO
+++ b/drivers/staging/vc04_services/interface/vchi/TODO
@@ -23,3 +23,30 @@ there's a lot code that got built that's probably unnecessary these
 days.  Once we have the set of VCHI-using drivers we want in tree, we
 should be able to do a sweep of the code to see what's left that's
+3) Make driver more portable
+Building this driver with arm/multi_v7_defconfig or arm64/defconfig
+leads to data corruption during vchiq_test. This should be fixed.
+4) Fix kernel module support
+Even the VPU firmware doesn't support a VCHI re-connect, the driver
+should properly handle a module unload. This also includes that all
+resources must be freed (kthreads, debugfs entries, ...) and global
+variables avoided.
+5) Fix stack hog
+Running make checkstack shows that vchiq_dump_service_use_state() has
+an extensive stack usage. Maybe other functions are also affected.
+6) Cleanup logging mechanism
+The driver should probably be using the standard kernel logging mechanisms
+such as dev_info, dev_dbg, and friends.
+7) Documentation
+A short top-down description of this driver's architecture (function of
+kthreads, userspace, limitations) could be very helpful for reviewers.

More information about the linux-rpi-kernel mailing list