[PATCH 4/4] ARM: dts: bcm2837-rpi-3-b: add GPIO expander

Peter Robinson pbrobinson at gmail.com
Wed Jan 3 19:06:47 PST 2018


>>> Stefan Wahren <stefan.wahren at i2se.com> hat am 2. Januar 2018 um 20:03
>>> geschrieben:
>>>
>>>
>>> Hi Baruch,
>>>
>>>> Baruch Siach <baruch at tkos.co.il> hat am 2. Januar 2018 um 14:19
>>>> geschrieben:
>>>
>>>
>>>> +               expgpio: expgpio {
>>>> +                       compatible = "brcm,bcm2835-expgpio";
>>>> +                       gpio-controller;
>>>> +                       #gpio-cells = <2>;
>>>> +                       firmware = <&firmware>;
>>>
>>>
>>> Please add the gpio-line-names from Eric's patch [1].
>>>
>>> Thanks
>>> Stefan
>>>
>>> [1] - https://patchwork.kernel.org/patch/9339857/
>>>
>>
>> sorry i missed the fact that the same GPIO expander is on the CM3. So
>> please move the exgpio node to bcm2837.dtsi and only define the
>> gpio-line-names in this file.
>
>
> The GPIO expander is not a part of the BCM2837 SoC, and not all
> BCM2837-based Pis have a GPIO expander - see the Pi 2+.

There's two ways that's generally handled upstream, either just
duplicate across the two .dts files or to put it in a separate .dtsi
and include it in the relevant .dts files, see arch/arm/boot/dts/axp*
as relevant examples.

Peter



More information about the linux-rpi-kernel mailing list