[PATCH 2/5] staging: bcm2835-camera: Fix integer underrun in port_parameter_get

Dan Carpenter dan.carpenter at oracle.com
Tue Mar 21 04:45:48 PDT 2017


On Tue, Mar 21, 2017 at 04:36:16AM -0700, Michael Zoran wrote:
> On Tue, 2017-03-21 at 13:41 +0300, Dan Carpenter wrote:
> > You're fixing a bug you introduced in [PATCH 1/5].  Don't do
> > that.  Just
> > fix Dave's patch and add a note in the commit log.
> > 
> > regards,
> > dan carpenter
> > 
> 
> OK, thanks I'm still learning about the whole process.  It looks like
> Dave's version has already been applied though.
> 
> I just want to have as much as possible a separation between what I'm
> passing upstream from the github(as a favor to him mostly) just to keep
> the two trees in sync, and what I'm submitting.  I don't want the logs
> to get too mixed up.  It's just a personal thing.
> 

Sure.  I understand that.  But please do what I am saying?

Also I feel like there should be a tag for bugfixes to a patch like:

Fixes-from: Michael Zoran <mzoran at crowfest.net>

A good deal of my work gets folded into the original patches and I don't
get any sort of credit that you can measure for it.  I've lobbied for
the Fixes-from: tag for a while...  It would only cover bug fixes not
bike shedding or style issues.

regards,
dan carpenter




More information about the linux-rpi-kernel mailing list