[PATCH] clocksource: add missing line break to error messages

Ben Dooks ben.dooks at codethink.co.uk
Tue Mar 14 02:40:07 PDT 2017

On 09/03/17 09:47, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal at milecki.pl>
> Printing with pr_* functions requires adding line break manually.
> Signed-off-by: Rafał Miłecki <rafal at milecki.pl>

I've had a quick look over and there are no obvious errors.

I wonder if the of_iomap() and related calls should print an
error if they fail as all the examples here are of the form

	ptr = of_iomap(reource)
	if (!ptr) {
		pr_err("cannot remap resource\n");
		return ERR;

Maybe we should look into this post this patch series.

Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

More information about the linux-rpi-kernel mailing list