[PATCH] serial: 8250: Fix THRE flag usage for CAP_MINI

Andy Shevchenko andriy.shevchenko at linux.intel.com
Tue Jun 27 02:15:36 PDT 2017

On Mon, 2017-06-26 at 16:15 +0100, Phil Elwell wrote:

> > But this looks like a bug / quirk than a capability?
> > 
> > It would be better to name this define more self-explaining.
> > 
> > Btw can't see the definition of UART_CAP_MINI?
> The capability was added in d087e7a991f1f61ee2c07db1be7c5cc2aa373f5d,
> which
> is in linux-next. Given that the "capability" already exists and the
> quirk
> is likely to be unique to BCM2835 MINI UART, I don't think we should
> create
> a new quirk.
> Besides, the "HFIFO" capability looks a lot like quirk to me.

To me either, which raises a question "Should it be fixed accordingly?"

Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Intel Finland Oy

More information about the linux-rpi-kernel mailing list