[PATCH RFT] spi: bcm2835: Remove unnecessary workaround to call gpio_set_value

Martin Sperl kernel at martin.sperl.org
Sat Feb 13 09:08:25 PST 2016

> On 13.02.2016, at 17:19, Axel Lin <axel.lin at ingics.com> wrote:
> This should be fixed by commit 4c02cba18cc9
> ("pinctrl: bcm2835: Fix initial value for direction_output")
> Signed-off-by: Axel Lin <axel.lin at ingics.com>

Actually this also solves the situation when the DT is configured
badly - and it is likely that old DTs are configured badly,
because it did not matter before (it was always wrong anyway).

This change would break those old DTs in this respect and can
result in unexpected behavior and undetected devices.

In this case it would be better to add a warning that the
GPIO is not configured in the DT correctly, so that it is
clear that the DT needs to change.

But then maybe a more generalized approach implemented
in the framework would be better...

More information about the linux-rpi-kernel mailing list