[PATCH] dmaengine: bcm2835-dma: Convert to use DMA pool

Eric Anholt eric at anholt.net
Tue Nov 24 10:34:13 PST 2015

Peter Ujfalusi <peter.ujfalusi at ti.com> writes:

> f93178291712 dmaengine: bcm2835-dma: Fix memory leak when stopping a
> 	     running transfer
> Fixed the memleak, but introduced another issue: the terminate_all callback
> might be called with interrupts disabled and the dma_free_coherent() is
> not allowed to be called when IRQs are disabled.
> Convert the driver to use dma_pool_* for managing the list of control
> blocks for the transfer.
> Fixes: f93178291712 ("dmaengine: bcm2835-dma: Fix memory leak when stopping a running transfer")
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi at ti.com>

It sounds like you got positive testing feedback.  Using the DMA pool
for our bcm2835_dma_cbs makes sense to me, too.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-rpi-kernel/attachments/20151124/938864d8/attachment.sig>

More information about the linux-rpi-kernel mailing list