usb: dwc2: regression during boot on Raspberry Pi

[Stefan Wahren]

Am 11.11.2015 um 22:58 schrieb John Youn:
> On 11/8/2015 2:13 AM, Stefan Wahren wrote:
>> --------------------------->8--------------------------------------------
>> diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
>> index 5859b0f..0e80087 100644
>> --- a/drivers/usb/dwc2/platform.c
>> +++ b/drivers/usb/dwc2/platform.c
>> @@ -341,20 +341,6 @@ static int dwc2_driver_probe(struct platform_device
>> *dev)
>>    	if (retval)
>>    		return retval;
>>
>> -	irq = platform_get_irq(dev, 0);
>> -	if (irq < 0) {
>> -		dev_err(&dev->dev, "missing IRQ resource\n");
>> -		return irq;
>> -	}
>> -
>> -	dev_dbg(hsotg->dev, "registering common handler for irq%d\n",
>> -		irq);
>> -	retval = devm_request_irq(hsotg->dev, irq,
>> -				  dwc2_handle_common_intr, IRQF_SHARED,
>> -				  dev_name(hsotg->dev), hsotg);
>> -	if (retval)
>> -		return retval;
>> -
>>    	res = platform_get_resource(dev, IORESOURCE_MEM, 0);
>>    	hsotg->regs = devm_ioremap_resource(&dev->dev, res);
>>    	if (IS_ERR(hsotg->regs))
>> @@ -389,6 +375,20 @@ static int dwc2_driver_probe(struct platform_device
>> *dev)
>>
>>    	dwc2_set_all_params(hsotg->core_params, -1);
>>
>> +	irq = platform_get_irq(dev, 0);
>> +	if (irq < 0) {
>> +		dev_err(&dev->dev, "missing IRQ resource\n");
>> +		return irq;
>> +	}
>> +
>> +	dev_dbg(hsotg->dev, "registering common handler for irq%d\n",
>> +		irq);
>> +	retval = devm_request_irq(hsotg->dev, irq,
>> +				  dwc2_handle_common_intr, IRQF_SHARED,
>> +				  dev_name(hsotg->dev), hsotg);
>> +	if (retval)
>> +		return retval;
>> +
>>    	retval = dwc2_lowlevel_hw_enable(hsotg);
>>    	if (retval)
>>    		return retval;
>>
>>
>
> Looks good to me. Could you submit a patch for this?
>

If i get USB working on the Pi then i will send you a clean patch.

Stefan

> Regards,
> John
>
>