[PATCH 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2.
swarren at wwwdotorg.org
Mon Jul 13 22:09:56 PDT 2015
On 07/11/2015 01:51 AM, Thomas Gleixner wrote:
> On Fri, 10 Jul 2015, Stephen Warren wrote:
>> On 07/07/2015 03:13 PM, Eric Anholt wrote:
>>> +static struct arm_local_intc intc __read_mostly;
>> It'd be nice to give everything (types, functions, variables) a
>> consistent symbol prefix; bcm2836_arm_irqchip_ sounds like a good
>> bikeshed to me, but perhaps just propagating the above arm_local_ to the
>> functions too would be good, although that seems to risk symbol name
>> collisions with other ARM SoCs.
> Which is irrelevant because its static.
Except if you want to look up a symbol name without having to qualify it
Or, does e.g. gdb require statics always be qualified even if they're
More information about the linux-rpi-kernel