[PATCH 2/3] spi: add initial set of spi_transfer transformation methods

Mark Brown broonie at kernel.org
Thu Dec 3 06:34:17 PST 2015

On Thu, Dec 03, 2015 at 07:22:10AM +0100, Martin Sperl wrote:
> > On 03.12.2015, at 01:36, Mark Brown <broonie at kernel.org> wrote:

> >> Rx/tx_dma is handled because it is there and it's address needs also to be
> >> accurately Shifted by that offset. I know that it is a depreciated interface,
> >> but as it is still there it needs to be supported...

> > It's really quite broken already for most users.

> If it is broken, then why not remove those members?

There are still a couple of users and someone needs to go through and
fix them.  I don't know which if any systems they run on, it's possible
that they manage to work as a result of the DMA mappings not getting in
the way the systems they're being used on (if they're being used at all)
or the controller drivers they're used with being equally aged.

> One last thing:
> Where do you prefer to run those transfer transformations?
> In the master-loop (before/after prepare message)?
> During spi_verify (or after it)?

Remember that we can't do any allocations in _verify() as it can run in
atomic context so while we want to check if we can take the message then
we are most likely going to be unable to implement transformations.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-rpi-kernel/attachments/20151203/7a95f921/attachment.sig>

More information about the linux-rpi-kernel mailing list