[RFC 0/5] replace sdhci-bcm2835 with bcm2835-mmc

Piotr Król piotr.krol at 3mdeb.com
Wed Oct 29 14:10:11 PDT 2014

On Tue, Oct 28, 2014 at 07:42:31PM -0600, Stephen Warren wrote:
> On 10/28/2014 06:00 PM, Piotr Król wrote:
> > Hi all, this patch series introduce bcm2835-mmc driver, which is
> > used in Raspberry Pi Foundation kernel. It also adds support for
> > slave_sg transfer mode in bcm2835-dma driver which is used by
> > bcm2835-mmc to decrease CPU utilization. This driver significantly
> > improves throughput and system CPU utilization in comparison with
> > sdhci-bcm2835. On my Kingston SDC10/8GB I have ~11MB/s writes with
> > 15s of sys CPU load, instead of ~700KB/s and 43s of sys CPU
> > utilization.
> > 
> > Almost all code coming from raspberrypi.org, so I'm looking for
> > feedback about missing/broken stuff and things that should be
> > redesigned.
> None of the patches have their git authorship set to the original
> authors, nor Signed-off-by lines for them. This information should
> match up with the original patches from the RPI Foundation tree,
> although sometimes that information is missing there too:-( Please
> take a look at Documentation/SubmittingPatches section "12) Sign your
> work".

thanks for your comments. Unfortunately there was no "Sign-off-by"
information in bcm2835-mmc. I would like to follow your suggestion from
first patch review and enhance sdhci-bcm2835 with coordination with

Do I still have to get Gellert sign-off  when sending small incremental
changes based on his work ? If yes the what if I can't get this sign-off
from Gellert ?

> Patches should be sent to relevant maintainers and mailing lists.
> ./scripts/get_maintainers.pl should tell you the relevant people and
> lists. In particular, I'd expect the following to be CC'd:
> * linux-arm mailing list since this series touches an ARM platform.
> * devicetree mailing list since this series touches DT bindings.
> * linux-mmc mailing list since this series implements an MMC driver.
> * bcm2835 and MMC maintainers.

Piotr Król

More information about the linux-rpi-kernel mailing list