[PATCH v3 1/8] drm/rockchip: vop2: Take the UV plane address from the second GEM object
Damon Ding
damon.ding at rock-chips.com
Tue Nov 17 22:21:53 PST 2026
On 11/14/2026 12:39 AM, Arun Iyengar via B4 Relay wrote:
> From: Arun Iyengar <aiyengar1990 at gmail.com>
>
> vop2_plane_atomic_update() takes the chroma plane address from
> fb->obj[0]. The planes of a framebuffer can be in different GEM objects
> (ADDFB2 with two handles, e.g. NV12M from a V4L2 decoder), and the
> window then fetches the chroma plane from the luma buffer.
>
> Use fb->obj[1] for formats with more than one plane.
>
> Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
> Reported-by: Sashiko <sashiko-bot at kernel.org>
> Closes: https://lore.kernel.org/all/sashiko-outbox-206550@kernel.org/
> Cc: stable at vger.kernel.org
> Signed-off-by: Arun Iyengar <aiyengar1990 at gmail.com>
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> index 76d151b8bc52..e8ef83d6924b 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> @@ -1369,7 +1369,8 @@ static void vop2_plane_atomic_update(struct drm_plane *plane,
> if ((pstate->rotation & DRM_MODE_REFLECT_Y) && !afbc_en)
> offset += fb->pitches[1] * ((pstate->src_h >> 16) - 2) / vsub;
>
> - rk_obj = to_rockchip_obj(fb->obj[0]);
> + if (fb->format->num_planes > 1)
> + rk_obj = to_rockchip_obj(fb->obj[1]);
> uv_mst = rk_obj->dma_addr + offset + fb->offsets[1];
> }
>
>
Reviewed-by: Damon Ding <damon.ding at rock-chips.com>
Best regards,
Damon
More information about the Linux-rockchip
mailing list