[PATCH] mmc: sdhci-of-dwcmshc: Change DLL_STRBIN_TAPNUM_DEFAULT to 0x4

[Shawn Lin]

在 2025/10/21 星期二 18:18, Ulf Hansson 写道:
> On Mon, 20 Oct 2025 at 03:50, Shawn Lin <shawn.lin at rock-chips.com> wrote:
>>
>> strbin signal delay under 0x8 configuration is not stable after massive
>> test. The recommandation of it should be 0x4.
>>
>> Signed-off-by: Shawn Lin <shawn.lin at rock-chips.com>
> 
> Do we need a fixes/stable-tag here too?
> 

Yes, we do.

Fixes: 08f3dff799d4 ("mmc: sdhci-of-dwcmshc: add rockchip platform support")

But I'd like to hold it for a while as I asked some other folks to test
this patch asap too . So let's wait to see if it also solves their
problems.

> Kind regards
> Uffe
> 
>> ---
>>
>>   drivers/mmc/host/sdhci-of-dwcmshc.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c
>> index eebd453..5b61401 100644
>> --- a/drivers/mmc/host/sdhci-of-dwcmshc.c
>> +++ b/drivers/mmc/host/sdhci-of-dwcmshc.c
>> @@ -94,7 +94,7 @@
>>   #define DLL_TXCLK_TAPNUM_DEFAULT       0x10
>>   #define DLL_TXCLK_TAPNUM_90_DEGREES    0xA
>>   #define DLL_TXCLK_TAPNUM_FROM_SW       BIT(24)
>> -#define DLL_STRBIN_TAPNUM_DEFAULT      0x8
>> +#define DLL_STRBIN_TAPNUM_DEFAULT      0x4
>>   #define DLL_STRBIN_TAPNUM_FROM_SW      BIT(24)
>>   #define DLL_STRBIN_DELAY_NUM_SEL       BIT(26)
>>   #define DLL_STRBIN_DELAY_NUM_OFFSET    16
>> --
>> 2.7.4
>>
>>
>