[PATCH v3 0/3] Consolidate and clarify LED device tree descriptions on Radxa boards
FUKAUMI Naoki
naoki at radxa.com
Thu Nov 13 04:42:19 PST 2025
Currently, on Radxa boards, the power LED is turned on immediately
after power-up, independent of software control. The heartbeat LED and
other available LEDs are subsequently turned on by the initial
software, such as U-Boot, to indicate software is running.
However, the device tree description for this behavior is inconsistent
and fragmented, with definitions split between the main Linux DTS
files and separate U-Boot files (u-boot/arch/arm/dts/*-u-boot.dtsi).
This patch series addresses this inconsistency and fragmentation by
consolidating the description within the upstream device tree, thereby
improving overall clarity.
Patch 1 addresses the inconsistency for the power LED by using
default-state = "on" instead of linux,default-trigger = "default-on".
Patch 2 addresses the description fragmentation for the heartbeat LED
by consolidating its default-state = "on" definition from the U-Boot
files into the main Linux DTS.
Patch 3 addresses inconsistency by removing redundant default-state =
"off" definitions, as this is already the default configuration.
This patch series does not address some LEDs that are (implicitly)
default-state = "off" at kernel but should be "on" at bootloader.
These will be addressed separately.
FUKAUMI Naoki (3):
arm64: dts: rockchip: Use default-state for power LED for Radxa boards
arm64: dts: rockchip: Turn on heartbeat LED at boot for Radxa boards
arm64: dts: rockchip: Remove default-state = "off" from LEDs for Radxa
boards
---
Changes in v3:
- Split into three patches
- Reword commit message
Changes in v2:
- Add more URLs for reference
- Reword commit message
---
arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts | 1 -
arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts | 1 +
arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts | 3 ++-
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 1 +
arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts | 2 --
arch/arm64/boot/dts/rockchip/rk3528-rock-2a.dts | 1 -
arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3-io.dts | 1 +
arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 1 +
arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi | 1 +
arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 1 +
arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts | 3 ++-
arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 2 --
arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts | 2 +-
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtsi | 1 +
arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts | 1 +
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 3 ++-
16 files changed, 15 insertions(+), 10 deletions(-)
--
2.43.0
More information about the Linux-rockchip
mailing list